Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template fixes #629

Merged
merged 25 commits into from
Feb 15, 2024
Merged

Template fixes #629

merged 25 commits into from
Feb 15, 2024

Conversation

neerdoc
Copy link
Collaborator

@neerdoc neerdoc commented Feb 15, 2024

  • Fixed problem with multiple templates for different documents. This will now give an error.
  • Fixed problem with doc attribute not being defined.
  • Updated a bunch of the actions in the runners due to node16 going obsolete.
  • Added an automation on the test coverage so that clear feedback is given to contributors if their code changes are not covered by tests.

neerdoc added 25 commits February 12, 2024 20:44
@neerdoc
Fix doorstop-dev#628, part 1. Missed check of "doc" in attributes_def…
3c57c44 
…ault.
@neerdoc
Added double template check and also allow any document to define the…
a545752 
… template.
@neerdoc
Set template to None as default.
184cc4e
@neerdoc
Ignore .python-version
9eccfb7
@neerdoc
Added fix for intermittent failing Windows tests due to race in folde…
3da2701 
…r ownership.
@neerdoc
Merge remote-tracking branch 'origin/develop' into template_fixes
8c92174
@neerdoc
Fixed make test-cover command.
7500243
@neerdoc
Added on_error_retry function to try to handle Windows testing.
880b910
@neerdoc
Updated tests rmtree to use the on_error_retry function.
51be0cd
@neerdoc
Added hook for stopping pushes of code without test coverage.
9a04c27
@neerdoc
Changed hook.
158515f
@neerdoc
Removed check from pre-commit hooks as this is not standard git.
880f777
@neerdoc
Added a test to check for change coverage.
5e304af
@neerdoc
Moved coverage test to only run on linux as this is enough.
874c7de
@neerdoc
Fixed rounding issue. 3.10 -> 3.1....
fdde19e
@neerdoc
Cleanup call tree and made the test fail.
e7436aa
@neerdoc
Not possible with shell expansion in gitlab actions.
3c741d3
@neerdoc
Need to run normal test first.
3be95d1
@neerdoc
Print out the develop commit hash.
8bd265c
@neerdoc
Debugging the CI-script.
bf6a45c
@neerdoc
Trying another way of comparing with develop.
070afbc
@neerdoc
Test original way but after pull.
c3bcd94
@neerdoc
Deeper fetch needed. Also updated action versions.
b125387
@neerdoc
Git fetch still needed.
388d97d
@neerdoc
Added missing test.
f258ae8
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ee89a99) 96.27% compared to head (f258ae8) 96.33%.
Report is 1 commits behind head on develop.

Files Patch % Lines
doorstop/core/publishers/base.py 93.75% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #629      +/-   ##
===========================================
+ Coverage    96.27%   96.33%   +0.06%     
===========================================
  Files           41       41              
  Lines         5151     5158       +7     
  Branches      1210      966     -244     
===========================================
+ Hits          4959     4969      +10     
+ Misses         121      117       -4     
- Partials        71       72       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neerdoc neerdoc mentioned this pull request Feb 15, 2024
Merged
@neerdoc neerdoc requested a review from jacebrowning February 15, 2024 11:25
@neerdoc neerdoc merged commit a49b946 into doorstop-dev:develop Feb 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacebrowning jacebrowning jacebrowning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neerdoc @codecov-commenter @jacebrowning